Skip to content

Conversation

@cbot59
Copy link
Contributor

@cbot59 cbot59 commented Oct 21, 2025

  • Introduce getRowsCount()
  • Add test

@mdeinum
Copy link
Collaborator

mdeinum commented Oct 27, 2025

The code looks fine, but what is the use-case for this and this might not work, as expected, using the streaming variant of the reader.

@cbot59
Copy link
Contributor Author

cbot59 commented Oct 27, 2025

The code looks fine, but what is the use-case for this and this might not work, as expected, using the streaming variant of the reader.

In my case, it helps provide an immediate return when a sheet reach N rows. More efficient logic and be able to go over the next sheet or other things.
Should we add javadoc that explains the method might be indeterministic depending on the Sheet implementation?

@mdeinum
Copy link
Collaborator

mdeinum commented Oct 28, 2025

Should we add javadoc that explains the method might be indeterministic depending on the Sheet implementation?

Please do as with a regular reader the number of rows is directly present but with streaming only when the specific element has been read while processing the sheet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants